Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MMI use cases in signing typed messages #1364

Merged
merged 10 commits into from
May 17, 2023
Merged

Support MMI use cases in signing typed messages #1364

merged 10 commits into from
May 17, 2023

Conversation

shane-t
Copy link
Member

@shane-t shane-t commented May 11, 2023 •
edited
Loading

Description

Changes

  • ADDED: Metadata property of messages, plus a method to mutate it
  • ADDED: A means of deferring the message setting as signed, via the params
  • ADDED: Method to get all messages
  • ADDED: Event to surface message signing to the client

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@shane-t shane-t mentioned this pull request May 12, 2023
Closed
@shane-t shane-t force-pushed the MMI-3035-mmi-use-cases branch from 03abb47 to 44a760b Compare May 12, 2023 13:18
@shane-t shane-t force-pushed the MMI-3035-mmi-use-cases branch from 44a760b to eea406c Compare May 15, 2023 08:52
@shane-t shane-t marked this pull request as ready for review May 15, 2023 09:43
@shane-t shane-t requested a review from a team as a code owner May 15, 2023 09:43
@shane-t shane-t merged commit 70f0394 into main May 17, 2023
@shane-t shane-t deleted the MMI-3035-mmi-use-cases branch May 17, 2023 09:59
brad-decker pushed a commit to dragana8/core that referenced this pull request Jun 1, 2023
@shane-t @brad-decker
Support MMI use cases in signing typed messages (MetaMask#1364)
38d30a3 
* feat(metadata): add metadata to message params

* chore: add deferSetAsSigned to message params

* chore: add getAllMessages method

* chore: add event to signaturecontroller

* chore: lint fixes

* chore: change event shape

* chore: add a second message so that the getAllMessages method gets a realistic array

* chore: use Json as the metadata type

* chore: simplify tests

* chore: fix message manager test
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@shane-t @MajorLift
Support MMI use cases in signing typed messages (#1364)
9db1854 
* feat(metadata): add metadata to message params

* chore: add deferSetAsSigned to message params

* chore: add getAllMessages method

* chore: add event to signaturecontroller

* chore: lint fixes

* chore: change event shape

* chore: add a second message so that the getAllMessages method gets a realistic array

* chore: use Json as the metadata type

* chore: simplify tests

* chore: fix message manager test
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@shane-t @MajorLift
Support MMI use cases in signing typed messages (#1364)
eddfa98 
* feat(metadata): add metadata to message params

* chore: add deferSetAsSigned to message params

* chore: add getAllMessages method

* chore: add event to signaturecontroller

* chore: lint fixes

* chore: change event shape

* chore: add a second message so that the getAllMessages method gets a realistic array

* chore: use Json as the metadata type

* chore: simplify tests

* chore: fix message manager test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MMI use cases
2 participants
@shane-t @matthewwalsh0